Repository navigation
Fix AV1 benchmark loading of input filepaths - #364
Draft
linjiaye929 wants to merge 1 commit into
Draft
linjiaye929 wants to merge 1 commit into
linjiaye929 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #328.
AV1 inherits Codec.run(), which passes an input filepath into _run_impl(). Converting that path directly with np.asarray() creates a scalar array and fails during the YUV transpose. Load the file through the shared _load_img() helper, as the other image codecs do, before converting to YUV.
Adds real AOM roundtrip regression tests for RGB, RGBA and grayscale PNG inputs using both str and pathlib.Path paths. The tests explicitly skip when aomenc/aomdec are unavailable.
Validation:
The existing JPEG fixture test, full test suite, GPU/Python matrix and upstream CI have not been verified. AOM regression tests may be skipped in CI if its external binaries are absent. Keeping this PR as a draft pending broader validation.
Prepared with AI assistance; test results above are from actual local runs.